Skip to content

Fix/6615 40 varchar limit on DatasetCollectionBinding and Embedding model name#6723

Merged
crazywoola merged 1 commit into
langgenius:mainfrom
HiroshigeAoki:fix/6615-40-varchar-limit-on-model-name
Jul 28, 2024
Merged

Fix/6615 40 varchar limit on DatasetCollectionBinding and Embedding model name#6723
crazywoola merged 1 commit into
langgenius:mainfrom
HiroshigeAoki:fix/6615-40-varchar-limit-on-model-name

Conversation

@HiroshigeAoki

@HiroshigeAoki HiroshigeAoki commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #6615

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Jul 26, 2024
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 27, 2024
@crazywoola
crazywoola merged commit e23461c into langgenius:main Jul 28, 2024
@mbbyn

mbbyn commented Jul 28, 2024

Copy link
Copy Markdown

I tested it, and it works perfectly! Thanks everyone 🎉

cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

40 VARCHAR Limit on Model Name

4 participants