Skip to content

feat: realtime scenario tests#154

Closed
drewdrewthis wants to merge 21 commits into
mainfrom
realtime-scenario-tests
Closed

feat: realtime scenario tests#154
drewdrewthis wants to merge 21 commits into
mainfrom
realtime-scenario-tests

Conversation

@drewdrewthis
Copy link
Copy Markdown
Collaborator

No description provided.

@rogeriochaves rogeriochaves force-pushed the main branch 2 times, most recently from 77a92af to 9fdb87c Compare December 16, 2025 15:54
@drewdrewthis drewdrewthis added the grinding Grinder is actively managing this PR label May 24, 2026
@drewdrewthis
Copy link
Copy Markdown
Collaborator Author

[grinder] BLOCKED — manual rebase required

`git merge-tree` found 157 conflict markers between this branch and current `main`. The branch has 10+ commits adding `javascript/examples/vitest/tests/realtime/` infrastructure that predates significant structural changes to the examples directory on main.

Autonomous rebase would require resolving 157 conflicts across JavaScript, TypeScript, and configuration files — this needs Drew's judgment to decide whether to:

  1. Rebase and resolve conflicts manually
  2. Close this PR and re-implement the realtime tests against the current example structure
  3. Cherry-pick only specific commits

Keeping `grinding` label. Will unblock when Drew makes the call.

@drewdrewthis drewdrewthis force-pushed the realtime-scenario-tests branch from d8edf1f to a638c29 Compare May 25, 2026 02:41
drewdrewthis and others added 2 commits May 25, 2026 03:09
…inder]

- Exclude realtime-client Vite sub-project from root ESLint config
- Add eslint-disable-any to client/main.ts for untyped SDK event handlers
- Fix import order and @ts-ignore@ts-expect-error in realtime-agent-adapter
- Fix import order in realtime-user-simulator.agent.ts
- Revert react-refresh disable comment from button.tsx (now excluded)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…der]

- Fix import order in vegetarian-recipe-realtime.test.ts
- Re-add react-refresh disable to button.tsx (inner ESLint needs it; outer ignores file)
- Rename event→_event at response.done listener (unused param warning)
- Remove unused react-hooks/immutability disable in orb.tsx

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
}

let targetIn = 0
let targetOut = 0.3
t = Math.imul(t, 0x21f0aaad)
t = t ^ (t >>> 15)
t = Math.imul(t, 0x735a2d97)
return ((t = t ^ (t >>> 15)) >>> 0) / 4294967296
…der]

voice-contract-surface.test.ts uses top-level await at line 79. TypeScript
requires target >= ES2017 when module=ESNext to allow top-level await.
The missing target field defaulted to ES3, causing TS1378 errors.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@drewdrewthis
Copy link
Copy Markdown
Collaborator Author

[grinder] BLOCKED — needs manual rebase

Multiple CI layers (lint sub-projects, TS top-level-await tsconfig, then test-examples) kept failing across 4+ fix iterations. Root cause: deep integration of realtime sub-packages with mismatched ESLint/TS configs requires hands-on dev attention.

Removing grinding label. Skipping per grinder policy (>15 min spent, no convergence).

@drewdrewthis drewdrewthis removed the grinding Grinder is actively managing this PR label May 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Automated low-risk assessment

This PR was evaluated against the repository's Low-Risk Pull Requests procedure and does not qualify as low risk.

This PR's diff exceeds the size limit for automated low-risk evaluation. Manual review required.

This PR requires a manual review before merging.

@drewdrewthis
Copy link
Copy Markdown
Collaborator Author

Closing — superseded and the approach is no longer supported. The OpenAI Realtime adapter is now GA on main (javascript/src/voice/adapters/openai-realtime.ts + python/scenario/voice/adapters/openai_realtime.py) via #604, and the official voice-testing stack landed in #561. This PR's early realtime-tests approach (incl. the realtime-client/ React demo) is the older method we no longer support. Thanks for the early exploration that informed the GA work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant