refactor: simplify scenario execution by removing complex turn manage…

[drewdrewthis]

…ment

• Remove pendingRolesOnTurn, pendingAgentsOnTurn, and turn orchestration logic
• Simplify user(), agent(), judge() methods to call agents directly
• Replace complex proceed() with simple user→agent→judge loop
• Remove scriptCallAgent and callAgent abstraction layers
• Keep fail-fast judge evaluation behavior
• Reduce code complexity from 682 lines to 136 lines in execution system

This maintains the same functionality while dramatically simplifying the codebase.

[drewdrewthis]

[grinder] BLOCKED — ACs not met, human decision needed

This PR (Nov 2025) aimed to simplify scenario execution from 682 → 136 lines by removing complex turn management. The main branch has since expanded the same files to 1,614 lines with substantially different architecture (voice adapter pattern, progressive discovery tools, span collectors, etc.).

During rebase, all 5 commits with conflicts in `scenario-execution.ts` were resolved in favor of HEAD — the simplification could not be applied without losing significant functionality added to main since Nov 2025.

What was actually merged: utility/doc additions from non-conflicted commits

• `javascript/src/domain/scenarios/script-commands.ts` (new)
• `javascript/src/execution/scenario-execution.utils.ts` (new)
• JSDoc cleanup pass

What was NOT applied: core simplification — user/agent/judge method rewrites, removal of turn orchestration.

CI: green (zero failing, zero pending — ci-checks skipped)

Options for Drew:

1. Close this PR (the simplification goal was superseded by the voice execution architecture)
2. Re-open as a fresh PR targeting the current execution architecture
3. Keep open as-is for the utility file additions only

Keeping the `grinding` label pending your decision.

[drewdrewthis]

[grinder] BLOCKED — ACs superseded, needs human decision

This Nov 2025 simplification (682→136 lines) is superseded by HEAD's 1614-line evolution. Conflicts resolved in favor of HEAD throughout rebase but the core AC (reduce to 136 lines) is fundamentally unmet. Needs Drew to decide: close as superseded, or rewrite ACs to match current HEAD?

Removing grinding label.

[github-actions]

Approved by automation: PR qualifies as low-risk-change under the documented policy.

[github-actions]

Automated low-risk assessment

This PR was evaluated against the repository's Low-Risk Pull Requests procedure.

• Scope: Update .cursor/rules/file-structure.mdc and add javascript/src/domain/scenarios/script-commands.ts (typed script command definitions) and javascript/src/execution/scenario-execution.utils.ts (utility functions for converting agent returns and extracting error info).
• Exclusions confirmed: no changes to auth, security settings, database schema, business-critical logic, or external integrations.
• Classification: low-risk-change under the documented policy.

The diff only modifies a documentation file and adds two new TypeScript files (typed script commands and scenario execution utilities). It does not touch authentication/authorization, secrets, database schemas/migrations, business‑critical logic, or external integrations, so it meets the low‑risk criteria. These changes are small, easily reverted, and do not alter protected systems or integrations.

An approving review has been submitted by automation. The PR may merge once required CI checks pass.

[github-actions]

Approved by automation: PR qualifies as low-risk-change under the documented policy.

[drewdrewthis]

[grinder] Standing skip — per operator instructions

This PR (#166) is listed in the grinder's skip list alongside #154 and #185. CI is green and it shows MERGEABLE, but the standing instruction from the session operator says to skip this PR entirely.

Removing grinding label. If Drew wants this driven to pr-ready, remove it from the skip list.

[drewdrewthis]

Closing as superseded by #561 (voice/TS consolidation). This PR modifies javascript/src/execution/scenario-execution.utils.ts and javascript/src/domain/scenarios/script-commands.ts, both of which were removed from main when #561 landed (both 404 on main). The execution architecture this refactor targets no longer exists, so there's nothing left to rebase onto. Thanks for the work — the simplification intent was largely absorbed into the consolidated stack.