fix(security): patch picomatch ReDoS in lovable_clone npm lockfile#409
fix(security): patch picomatch ReDoS in lovable_clone npm lockfile#409Aryansharma28 merged 3 commits intomainfrom
Conversation
Dependency Impact Assessment: picomatch override1. WHERE IS THIS DEPENDENCY USED?No source files in this repo import picomatch directly. Searched all 2. PRODUCTION CODE IMPACTNone. picomatch is not imported anywhere in 3. SCOPE: Examples onlyThis override affects only 4. VERSION JUMP SIZE — FLAGThis is the main risk. The override Three transitive consumers in the lockfile request
The npm override forces all of them to use 4.0.4 instead of 2.x. I checked whether picomatch 4.x breaks compatibility:
However, using 5. PINNED VERSION COMMENTSNone found. No comments in the codebase mention picomatch version pins, constraints, or upgrade warnings. 6. TRANSITIVE vs DIRECTTransitive only. picomatch is not listed in 7. FINAL VERDICT: LOW RISK — but the override range should be tightenedClassification: LOW RISK — this is a transitive dev-only dependency in an example template, not imported anywhere in production or test code. Recommendation: Change the override from I will push this fix in a follow-up commit. |
|
CI green — all 6 checks pass (CodeQL Analyze x2, Validate PR Title, semantic-pull-request, evaluate, test). Ready for review. |
Tighten override from ">=2.3.2" to ">=2.3.2 <3.0.0" to avoid unnecessary major version jump (2.3.1 → 4.0.4). The CVE fix is in 2.3.2, so staying within 2.x avoids breaking the vite/chokidar stack that expects picomatch ^2.x.
223bdeb to
dce556d
Compare
Resolved override conflict in package.json by keeping rollup, flatted (both from main) and picomatch (from this branch). package-lock.json regenerated against current main; picomatch resolves to 2.3.2 (the CVE fix). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Automated low-risk assessment This PR was evaluated against the repository's Low-Risk Pull Requests procedure and does not qualify as low risk.
This PR requires a manual review before merging. |
Summary
Adds npm overrides for picomatch in python/examples/lovable_clone/template to fix:
Note: pnpm-lock.yaml for the same directory is handled by PR #394.
Part of #400
Test plan
npm install --package-lock-onlysucceeds