fix(security): upgrade picomatch, @hono/node-server, and glob to fix CVEs#394
Conversation
eb95c6a to
a0a6c2e
Compare
Security Impact AssessmentDeep analysis of each dependency upgrade to confirm safety before merging. 1.
|
| Package | Production code? | Shipped in npm? | Version bump type | Breaking changes? | CVE applies? |
|---|---|---|---|---|---|
| picomatch | ❌ Dev/build only | ❌ | Patch (2.3.1→2.3.2, 4.0.3→4.0.4) | ❌ | Theoretical (ReDoS with untrusted globs) |
| @hono/node-server | ❌ Docs dev server only | ❌ | Patch (1.19.6→1.19.10) | ❌ | Theoretical (auth bypass on static paths) |
| glob | ❌ Docs build tooling only | ❌ | Minor (10.4.5→10.5.0) | ❌ | ❌ CLI-only, not used |
All three vulnerabilities are in transitive dev/build dependencies that never reach production. The actual security risk to this project is negligible, but the overrides are the right fix for Vanta/compliance — they eliminate the alerts with zero risk of regression.
Risk of breakage
None. All version bumps are patch or minor, all packages are dev-time only, and none are directly imported. The lockfiles regenerated cleanly with pnpm install --lockfile-only.
e132c44 to
71500ed
Compare
dfebae4 to
560fe2c
Compare
6be5a40 to
a0ab1ed
Compare
…CVEs Override transitive dependencies to patched versions: - picomatch >=2.3.2 / >=4.0.4 (CVE-2026-33671, ReDoS via extglob) - @hono/node-server >=1.19.10 (CVE-2026-29087, auth bypass via encoded slashes) - glob >=10.5.0 (CVE-2025-64756, CLI command injection via shell:true) Resolves dependabot alerts #281, #198, #67.
a0ab1ed to
bc6eac2
Compare
chore(tests): remove flaky live-LLM travel-agent example test The test runs 9 scripted live LLM turns with sequential weather + accommodation tool calls under a 180s timeout. It has been timing out or failing tool-call assertions on unrelated PRs (e.g. #394's dependency overrides change). Coverage is preserved: multi-tool agent flow is already demonstrated deterministically by `database-tool-mocking.test.ts`, and the live-LLM single-tool pattern is in `weather-agent.test.ts`. Follow-up to #423 and #424.
|
Automated low-risk assessment This PR was evaluated against the repository's Low-Risk Pull Requests procedure and does not qualify as low risk.
This PR requires a manual review before merging. |
Summary
Resolves three high-severity Dependabot security alerts by adding
pnpm.overridesto force patched transitive dependency versions:>=2.3.2/>=4.0.4— CVE-2026-33671 (ReDoS via extglob quantifiers)>=1.19.10— CVE-2026-29087 (authorization bypass for protected static paths via encoded slashes)>=10.5.0— CVE-2025-64756 (CLI command injection via-c/--cmdwithshell:true)Affected lockfiles
javascript/pnpm-lock.yamldocs/pnpm-lock.yamlpython/examples/lovable_clone/template/pnpm-lock.yamlCloses https://github.com/langwatch/scenario/security/dependabot/281
Closes https://github.com/langwatch/scenario/security/dependabot/198
Closes https://github.com/langwatch/scenario/security/dependabot/67
Test plan
pnpm install --lockfile-onlysucceeds in all affected directories