chore(tests): remove no-op example tests + audit notes#424
Merged
Aryansharma28 merged 1 commit intomainfrom May 4, 2026
Merged
chore(tests): remove no-op example tests + audit notes#424Aryansharma28 merged 1 commit intomainfrom
Aryansharma28 merged 1 commit intomainfrom
Conversation
- Drop `vegetarian-recipe-realtime.test.ts` — its only test is `it.skip`, so the whole file ran nothing. - Remove the `handles adversarial users and conversational chaos` test in `multilingual-agent.test.ts` — its assertion was wrapped in a try/catch with `expect(true).toBe(true)` and a "TODO: flaky, let it pass for now" comment, so it always passed regardless of behaviour and consumed up to 360s of CI time on every PR.
Contributor
|
Automated low-risk assessment This PR was evaluated against the repository's Low-Risk Pull Requests procedure.
This classification allows merging without manual review once all required CI checks are passing and branch protection rules are satisfied. |
1 task
Aryansharma28
added a commit
that referenced
this pull request
May 4, 2026
chore(tests): remove flaky live-LLM travel-agent example test The test runs 9 scripted live LLM turns with sequential weather + accommodation tool calls under a 180s timeout. It has been timing out or failing tool-call assertions on unrelated PRs (e.g. #394's dependency overrides change). Coverage is preserved: multi-tool agent flow is already demonstrated deterministically by `database-tool-mocking.test.ts`, and the live-LLM single-tool pattern is in `weather-agent.test.ts`. Follow-up to #423 and #424.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two example tests that produce no signal but consume CI time on every PR:
Follow-up to #423 (which removed the flaky `multiturn-10-scripted.test.ts`).
Audit notes — flagged for discussion (not in this PR)
These came up in the audit but I'm not removing them unilaterally:
Test plan