Skip to content

Add Parallel File Parsing and Improve testing#31

Merged
clevelam merged 13 commits into
masterfrom
parallel
Jan 9, 2024
Merged

Add Parallel File Parsing and Improve testing#31
clevelam merged 13 commits into
masterfrom
parallel

Conversation

@clevelam

@clevelam clevelam commented Jan 5, 2024

Copy link
Copy Markdown
Collaborator

This enables parallel file processing for outputs, tallies, and dumps but default.

  • Add mutliprocessing tasks to parallelize multiple file parsing
  • Enabled by default but can be disabled by setting an environment variable OPPPY_USE_THREADS=False
  • Add log scaling option for 2d contours
  • Add golds for test_dump_utiles.py, test_output.py, and test_tally.py
  • Add pass/fail checking for test_interacitve
  • Add log scaling testing for 2d contours
  • Add 'SHOW_PLOTS' testing environment variable to hide plots while testing
  • Add 'OPPPY_UPGOLDS' testing environment variable to automate the update of the new OPPPY test golds.

@clevelam

clevelam commented Jan 5, 2024

Copy link
Copy Markdown
Collaborator Author

@tylerjereddy One more request. Would you be willing to review this Change set. Primarily I would like feedback on my multiprocessing implementation. I've found that this drastically speeds up the parsing for large number file sets.

@tylerjereddy tylerjereddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some initial comments/thoughts, a lot of it related to testing robustness to be confident in the parallel behavior.

I didn't try to check if the new functionality is actually faster, the community like using https://github.com/airspeed-velocity/asv for that, although this is quite formal so may be too much if you already have the performance envidence you need.

Comment thread opppy/dump_utils.py Outdated
Comment thread opppy/dump_utils.py Outdated
Comment thread opppy/dump_utils.py Outdated
Comment thread opppy/dump_utils.py
Comment thread opppy/dump_utils.py
Comment thread opppy/output.py
Comment thread opppy/output.py
Comment thread opppy/plot_dump_dictionary.py
Comment thread opppy/tally.py
Comment thread opppy/tally.py
@clevelam clevelam changed the title Add Parallel File Parsing Add Parallel File Parsing and Improve testing Jan 8, 2024
@clevelam

clevelam commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks for the feedback @tylerjereddy I've significantly updated the testing and opened a couple of follow on issues.

#35
#34

@clevelam
clevelam merged commit e852606 into master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants