Skip to content

Deprecate fortran interface#644

Merged
adamdempsey90 merged 3 commits into
mainfrom
dempsey/fort
Jul 16, 2026
Merged

Deprecate fortran interface#644
adamdempsey90 merged 3 commits into
mainfrom
dempsey/fort

Conversation

@adamdempsey90

Copy link
Copy Markdown
Collaborator

PR Summary

Not sure if we want to do more

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add warnings to the fortran functions? Perhaps guarded by a debug macro?

@adamdempsey90

Copy link
Copy Markdown
Collaborator Author

Should we also add warnings to the fortran functions? Perhaps guarded by a debug macro?

Added something to the f90 file.

@Yurlungur

Copy link
Copy Markdown
Collaborator

Should we also add warnings to the fortran functions? Perhaps guarded by a debug macro?

Added something to the f90 file.

that strategy looks good to me

@adamdempsey90
adamdempsey90 merged commit 7603d2e into main Jul 16, 2026
9 checks passed
@adamdempsey90
adamdempsey90 deleted the dempsey/fort branch July 16, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants