Add Windows as a supported platform (CI green on windows-latest)#1
Merged
Conversation
Re-adding windows-latest to the CI matrices surfaced five Windows-only failures. Fixes: - cli: reconfigure stdout/stderr to UTF-8 in main() so the "✓" status lines (and any Greek letters/arrows) no longer raise UnicodeEncodeError under the cp1252 console/pipe encoding. This unblocks both the CLI subprocess integration test and the wheel/sdist artifact smoke jobs. - numerical validator: use a strict "<" comparison in the sample evaluation budget check so a zero-second budget always trips, even where time.monotonic() has coarse resolution and reports elapsed == 0.0. - biomodels_batch/utils: make the timeout mechanism cross-platform. signal.alarm/SIGALRM stay on Unix; Windows falls back to a worker-thread join, preserving shared-argument mutation and TimeoutError semantics. - run_biomodels_benchmark: build the isolated-env PATH with os.pathsep instead of a hardcoded ":", which split "C:\..." on Windows. - tests: write the evidence fixture with newline="\n" so its on-disk byte size is stable across platforms, and split PATH on os.pathsep.
process_model timed the recast with time.time(), whose ~15 ms resolution on Windows can report a 0.0 elapsed for a fast recast. That zeroed the open-phase interval used to attribute a timeout to its in-flight phase, leaving recast_dominant_phase empty. Use time.perf_counter(), matching the high-resolution phase timing already used inside attempt_recast.
Windows (3.10/3.11/3.12) now passes CI alongside Linux and macOS, so add the Windows operating-system classifier and update the README platform note.
wshlavacek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes ssys build and pass CI on Windows, and advertises Windows as a supported platform.
windows-latestis re-added to both thetestandartifact-smokematrices (Python 3.10/3.11/3.12), joining Linux and macOS.Re-adding the Windows runners surfaced a handful of Windows-only failures, each fixed below.
Fixes
src/ssys/cli.py): reconfigurestdout/stderrto UTF-8 inmain()so the✓status lines (and any Greek letters / arrows) no longer raiseUnicodeEncodeErrorunder the Windows cp1252 console/pipe encoding. This unblocked both the CLI subprocess integration test and the wheel/sdist artifact-smoke jobs.src/ssys/_validator/numerical.py): use a strict<comparison in the sample-evaluation budget check so a zero-second budget always trips, even wheretime.monotonic()has coarse resolution and reportselapsed == 0.0at the first check.biomodels_batch/utils.py):signal.alarm/SIGALRMare Unix-only. They stay on Unix; on Windows the timeout falls back to a worker-threadjoin, preserving shared-argument mutation andTimeoutErrorsemantics.biomodels_batch/step3_recast.py): measure the recast elapsed withtime.perf_counter()instead oftime.time(), matching the phase timing insideattempt_recast.time.time()'s ~15 ms resolution on Windows could report0.0elapsed and suppress the open-phase interval used to attribute timeouts.tools/run_biomodels_benchmark.py): build the isolated-environmentPATHwithos.pathsepinstead of a hardcoded:, which splitC:\...on Windows.tests/): write the evidence fixture withnewline="\n"so its on-disk byte size is stable across platforms, and splitPATHonos.pathsep.Advertising
pyproject.toml: add theOperating System :: Microsoft :: Windowsclassifier.README.md: update the supported-platforms note to include Windows.Verification
All CI jobs are green on
windows-latest,ubuntu-latest, andmacos-latest(3.10/3.11/3.12), including the type-check, build, artifact-smoke, sdist-artifact-smoke, and slow Linux integration jobs. The Windows-only timeout thread path was additionally exercised locally by forcing the no-SIGALRMbranch.