Remove the redundant "Errors only" quick filter - #43
Merged
Conversation
"Errors only" kept only E/F level rows — exactly what the Level column
picker already does by selecting E and F. Having two ways to filter by
level added clutter and could confuse ("Level shows only I" + "Errors
only" → empty result with no obvious cause).
Drop the checkbox and its FilterSpec field; level filtering via the
column picker fully covers the use case. The flag was session-only UI
state (never persisted), so no config migration is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the "Errors only" quick-filter checkbox from the options panel.
Why
It kept only
E/Flevel rows — exactly what the Level column picker already does by selecting E and F. Two overlapping ways to filter by level:Icombined with "Errors only" yields an empty result (I ∩ E/F = ∅) with no obvious cause.The column picker fully covers the "show only errors" use case.
Changes
errors_onlycheckbox from the options panel.errors_onlyfield fromFilterSpecandUiState, and the branch inFilterSpec::matches.errors_onlyi18n strings (en + zh) and the now-obsoleteerrors_only_filterstest; adjust two tests that incidentally set the flag.The flag was session-only UI state (never written to config), so there is no config migration needed.
Testing
cargo test— 99 pass.cargo clippy— clean.