Show a hint when filters hide every row instead of a blank table - #53
Merged
Conversation
When entries are loaded but the active filters match nothing, the table body rendered zero rows — an empty panel identical whether caused by a typo'd Find, a stale column filter, or "bookmarks only" with no bookmarks, with no visible cause. Render a "No rows match the active filters" hint in the remainder column (which always fills the width, so it isn't clipped). Distinct from the empty-model view, which keeps showing the shortcut hints.
3 tasks
laomou
added a commit
that referenced
this pull request
Aug 6, 2026
The "no rows match the active filters" hint (from #53) sat in one table column a few rows down, which read as awkward. Instead, when entries are loaded but the active filters hide every one of them, render the status-bar "filtered 0" count itself in bold orange — compact, and it points right at the count that explains the empty table. The table area stays clean and the now-unused no_matches string is removed.
laomou
added a commit
that referenced
this pull request
Aug 6, 2026
The "no rows match the active filters" hint (from #53) sat in one table column a few rows down, which read as awkward. Instead, when entries are loaded but the active filters hide every one of them, render the status-bar "filtered 0" count itself in bold orange — compact, and it points right at the count that explains the empty table. The table area stays clean and the now-unused no_matches string is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a log is loaded but the active filters match nothing, the table body rendered zero rows — a blank panel identical whether the cause was a typo'd Find term, a stale column filter (PID/TID/tag/level), or "Bookmarks only" with no bookmarks. There was no in-context explanation of why the table was empty.
Now it renders a centered "No rows match the active filters" hint (localized) in the remainder column, which always fills the width so the text isn't clipped. This is distinct from the empty-model state (no file / cleared), which keeps showing the keyboard-shortcut hints.
Test plan
all_rows_filtered_out_renders_no_matches_hint_without_panic— a non-matching Find hides every row and the hint renders without panic