Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
"require": {
"php": ">=5.5.9",
"doctrine/migrations": "~1.1",
"illuminate/config": "~5.1",
"illuminate/contracts": "~5.1",
"illuminate/console": "~5.1",
"illuminate/support": "~5.1",
"laravel-doctrine/orm": "1.0.*|1.1.*|1.2.*"
},
"require-dev": {
Expand Down
14 changes: 7 additions & 7 deletions src/Configuration/ConfigurationFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
namespace LaravelDoctrine\Migrations\Configuration;

use Doctrine\DBAL\Connection;
use Illuminate\Contracts\Config\Repository;
use Illuminate\Config\Repository;
use Illuminate\Contracts\Config\Repository as ConfigRepository;
use Illuminate\Contracts\Container\Container;
use Illuminate\Support\Collection;
use LaravelDoctrine\Migrations\Naming\DefaultNamingStrategy;

class ConfigurationFactory
{
/**
* @var Repository
* @var ConfigRepository
*/
protected $config;

Expand All @@ -21,10 +21,10 @@ class ConfigurationFactory
protected $container;

/**
* @param Repository $config
* @param ConfigRepository $config
* @param Container $container
*/
public function __construct(Repository $config, Container $container)
public function __construct(ConfigRepository $config, Container $container)
{
$this->config = $config;
$this->container = $container;
Expand All @@ -39,9 +39,9 @@ public function __construct(Repository $config, Container $container)
public function make(Connection $connection, $name = null)
{
if ($name && $this->config->has('migrations.' . $name)) {
$config = new Collection($this->config->get('migrations.' . $name, []));
$config = new Repository($this->config->get('migrations.' . $name, []));
} else {
$config = new Collection($this->config->get('migrations.default', []));
$config = new Repository($this->config->get('migrations.default', []));
}

$configuration = new Configuration($connection);
Expand Down
15 changes: 9 additions & 6 deletions tests/Configuration/ConfigurationFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ public function test_can_make_configuration()
'name' => 'Doctrine Migrations',
'namespace' => 'Database\\Migrations',
'table' => 'migrations',
'schema.filter' => '/^(?).*$/',
'schema' => ['filter' => '/^(?).*$/'],
'directory' => database_path('migrations'),
'naming_strategy' => DefaultNamingStrategy::class,
])
;

$this->configuration->shouldReceive('setFilterSchemaAssetsExpression')->with('/^(?).*$/')->once();
$this->configuration->shouldReceive('setFilterSchemaAssetsExpression')->with(m::mustBe('/^(?).*$/'))->once();

$this->container->shouldReceive('make')
->with(DefaultNamingStrategy::class)
Expand Down Expand Up @@ -99,13 +99,16 @@ public function test_can_make_configuration_for_custom_entity_manager()
'name' => 'Migrations',
'namespace' => 'Database\\Migrations\\Custom',
'table' => 'migrations',
'schema.filter' => '/^(?).*$/',
'schema' => ['filter' => '/^(?!^(custom)$).*$/'],
'directory' => database_path('migrations/custom'),
'naming_strategy' => DefaultNamingStrategy::class,
])
;

$this->configuration->shouldReceive('setFilterSchemaAssetsExpression')->with('/^(?).*$/')->once();
$this->configuration->shouldReceive('setFilterSchemaAssetsExpression')
->with(m::mustBe('/^(?!^(custom)$).*$/'))
->once()
;
$this->container->shouldReceive('make')
->with(DefaultNamingStrategy::class)
->once()
Expand Down Expand Up @@ -138,13 +141,13 @@ public function test_returns_default_configuration_if_not_defined()
'name' => 'Doctrine Migrations',
'namespace' => 'Database\\Migrations',
'table' => 'migrations',
'schema.filter' => '/^(?).*$/',
'schema' => ['filter' => '/^(?).*$/'],
'directory' => database_path('migrations'),
'naming_strategy' => DefaultNamingStrategy::class,
])
;

$this->configuration->shouldReceive('setFilterSchemaAssetsExpression')->with('/^(?).*$/')->once();
$this->configuration->shouldReceive('setFilterSchemaAssetsExpression')->with(m::mustBe('/^(?).*$/'))->once();
$this->container->shouldReceive('make')
->with(DefaultNamingStrategy::class)
->once()
Expand Down