Skip to content

Improve argument decoding error handling in ExecuteToolCommand - #896

Merged
pushpak1300 merged 1 commit into
laravel:mainfrom
AmadulHaque:main
Aug 7, 2026
Merged

Improve argument decoding error handling in ExecuteToolCommand#896
pushpak1300 merged 1 commit into
laravel:mainfrom
AmadulHaque:main

Conversation

@AmadulHaque

Copy link
Copy Markdown
Contributor

Summary

Improve input validation for the boost:execute-tool command by validating the Base64-encoded arguments before attempting to decode the JSON payload.

Changes

  • Validate the result of base64_decode() before calling json_decode().
  • Return a clear error when the provided arguments are not valid Base64.
  • Keep existing JSON validation for malformed payloads.
  • Update tests to cover the new validation behavior and remove the test that expected a TypeError.

@pushpak1300
pushpak1300 merged commit 326c27b into laravel:main Aug 7, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants