Skip vendor guidelines that fail to render instead of crashing - #911
Merged
Conversation
pushpak1300
marked this pull request as ready for review
August 4, 2026 21:01
Signed-off-by: Pushpak Chhajed <pushpak1300@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages ship their own guidelines and skills under
resources/boost, and Boost renders those Blade files at install time. If one of them targets an API that Boost has since changed, the whole install dies:inertiajs/inertia-laravelandlaravel/wayfinderboth still call the Roster enum that #891 moved toPackageRegistry(wayfinder's skill also uses$assist->roster, now$assist->project). Upstream main isn't fixed yet, socomposer updatedoesn't help. Either way, one stale vendor file taking down the entire install feels wrong.Now a file that fails to render is skipped, Boost falls back to its own bundled copy of that guideline when it has one, and the user gets told at the end of the install:
Skills already got the fallback for free, since one that fails to parse drops out of the merge and the
.aicopy stays.One gap that fallback exposed: the bundled
.ai/inertia-laravel/core.blade.phponly knew v1 and v2, while the package ships v3 guidance. Falling back would have quietly downgraded anyone on Inertia 3, so this pulls the v3 section in behind agte('3.0.0')branch. Wayfinder needed nothing, its bundled copies are already identical to upstream apart from the corrected API.Also adds an UPGRADE.md section covering the authoring API changes from #891 (
Packagesenum toPackageRegistry,$assist->rosterto$assist->project,usesVersion()touses()), since package authors hitting this crash have nowhere to look right now. I guessed at the2.5 From 2.4heading, rename it to whatever the release ends up being.I deliberately didn't shim the removed enum. Declaring a class in Roster's namespace to keep old templates rendering means owning a removed API forever, and it only covers this one break. The real fix belongs in those two packages, patches for both are ready but can't land until a release ships
PackageRegistry.Verified against the real broken files in a local project: both crashes become skips, and Inertia v3 plus the Wayfinder guideline and skill still land. Tests added for the skip, the fallback, the install warning, and the Inertia version branches.