Skip to content

Fix non-GitHub SSH remote validation - #986

Merged
pushpak1300 merged 3 commits into
laravel:mainfrom
simonyang08:codex/boost982-ssh-host
Sep 2, 2026
Merged

Fix non-GitHub SSH remote validation#986
pushpak1300 merged 3 commits into
laravel:mainfrom
simonyang08:codex/boost982-ssh-host

Conversation

@simonyang08

Copy link
Copy Markdown
Contributor

Closes #982

Summary

  • accept GitHub SCP-style and ssh:// remote URLs
  • reject SSH remotes whose host is not GitHub
  • keep existing HTTPS, branch, and nested skill-path handling unchanged

Root cause

Non-GitHub SSH remotes were treated as plain owner/repository strings. That allowed them to reach the GitHub API and fail later with a misleading 404 instead of reporting that the host is unsupported.

User impact

Users now get an immediate, accurate validation error for unsupported SSH hosts. Existing GitHub SSH forms such as git@github.com:owner/repo.git and ssh://git@github.com/owner/repo.git continue to work.

Validation

  • vendor/bin/pest tests/Unit/Skills/Remote/GitHubRepositoryTest.php - 32 passed, 79 assertions
  • vendor/bin/phpstan analyse src/Skills/Remote/GitHubRepository.php --no-progress - passed
  • full Pest suite - 1,012 passed; 8 unrelated WSL/configuration failures; 1 todo; 10 skipped
  • git diff --check - passed

The full-suite failures involve existing wsl.exe and configuration expectations and do not touch the changed files.

AI disclosure

This change was prepared with OpenAI Codex assistance and reviewed and validated locally by the contributor.

@github-actions

Copy link
Copy Markdown

Thanks for submitting a PR!

Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@simonyang08 simonyang08 changed the title [codex] Fix non-GitHub SSH remote validation Fix non-GitHub SSH remote validation Aug 28, 2026
@simonyang08
simonyang08 marked this pull request as ready for review August 28, 2026 10:44
@pushpak1300
pushpak1300 merged commit 5b33d49 into laravel:main Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost:add-skill treats an SSH remote as a GitHub repository and fails with a misleading 404

3 participants