Fix non-GitHub SSH remote validation - #986
Merged
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
simonyang08
marked this pull request as ready for review
August 28, 2026 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #982
Summary
ssh://remote URLsRoot cause
Non-GitHub SSH remotes were treated as plain
owner/repositorystrings. That allowed them to reach the GitHub API and fail later with a misleading 404 instead of reporting that the host is unsupported.User impact
Users now get an immediate, accurate validation error for unsupported SSH hosts. Existing GitHub SSH forms such as
git@github.com:owner/repo.gitandssh://git@github.com/owner/repo.gitcontinue to work.Validation
vendor/bin/pest tests/Unit/Skills/Remote/GitHubRepositoryTest.php- 32 passed, 79 assertionsvendor/bin/phpstan analyse src/Skills/Remote/GitHubRepository.php --no-progress- passedgit diff --check- passedThe full-suite failures involve existing
wsl.exeand configuration expectations and do not touch the changed files.AI disclosure
This change was prepared with OpenAI Codex assistance and reviewed and validated locally by the contributor.