Register the browser-logs route only when the browser logs watcher is enabled - #993
Merged
pushpak1300 merged 1 commit intoSep 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerRoutes() runs outside the browser_logs_watcher guard but registerBrowserLogger() runs inside it so turning the watcher off still leaves POST /_boost/browser-logs registered with no
browserlog channel behind it. any POST to it 500s and drops a laravel.EMERGENCY entry with a full stack trace into laravel.logtried it on a fresh laravel app with BOOST_BROWSER_LOGS_WATCHER=false, route:list still shows the route and posting to it returns 500 plus "Unable to create configured logger. Using emergency logger." in laravel.log every time. with this change the route is gone and the same POST just 404s, watcher back on and it registers like before
fix is moving registerRoutes() into the existing config check
re-file of #974, reviewed and re-tested individually