[5.3] Make str_replace_array() not interpret needle as a regex#12259
Merged
Conversation
| /** | ||
| * Replace a given value in the string sequentially with an array. | ||
| * | ||
| * @param string $search |
Collaborator
There was a problem hiding this comment.
Please don't align.
Contributor
Author
There was a problem hiding this comment.
This would reduce consistency with the rest of Str.php and helpers.php files.
I think it would be better to change code style in whole files at once, and in a dedicated commit.
Member
|
Needs full description of purpose of this change, what it does, what it fixes, purpose for existing, etc. |
Contributor
Author
|
My guess is that when you implemented this function (in ab0fa95) you just thought "it's handled as a regex, but what's the big deal?". There was a similar situation with There is kind of a convention, that PHP functions |
taylorotwell
added a commit
that referenced
this pull request
Feb 16, 2016
[5.3] Make str_replace_array() not interpret needle as a regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Str::replaceArraymethod for codebase consistency.