[11.x] Fix: Ensure generated policies return boolean values#53630
Closed
Aluisio-Pires wants to merge 1 commit intolaravel:11.xfrom
Closed
[11.x] Fix: Ensure generated policies return boolean values#53630Aluisio-Pires wants to merge 1 commit intolaravel:11.xfrom
Aluisio-Pires wants to merge 1 commit intolaravel:11.xfrom
Conversation
Contributor
|
This would be a security issue. If this were to be changed, it should be deny by default. |
Member
|
See above. |
Contributor
Author
Really good point. I was avoiding the same FormRequests behavior were we are forced to change the authorize return, but I see the issue. I will reopen de PR changing to false. |
Contributor
Author
@taylorotwell I've created a new PR following the recommendations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue where the methods in policies generated via commands such as
make:model ModelName --policyreturned abooltype but lacked implementations, causing PhpStan to report type errors. The problem stems from the empty method bodies in the default policy stubs.Changes Made
truereturn values for all methods:viewAnyviewcreateupdatedeleterestoreforceDeleteThis ensures the generated methods comply with their defined return types and eliminates PhpStan type-checking errors.
How to Test
php artisan make:model Example --policy.truereturn values.Impact
This change improves developer experience by making generated policies immediately usable without requiring manual fixes to satisfy static analysis.
Let me know if further details are needed!