[12.x] Use JS to create the Laravel ASCII SVG logo on the fly #58719
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this SVG is just the same two paths rendered over and over again on a perfect terminal grid, we can massively shrink the inlined size of the SVG by rendering it with JavaScript using RLE (Run Length Encoding). Before: 89,023 bytes (484,749 until recently) After: 3,816 bytes
Member
|
Thanks! |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this SVG is just the same two paths rendered over and over again on a regular terminal grid, we can massively shrink the inlined size of the SVG by rendering it with JavaScript using RLE (Run Length Encoding).
e.g.
10A212.9A|= "10 × 1, 212 × space, 9 × 1, newline"Before: 89,023 bytes (484,749 until recently)
After: 3,816 bytes
Despite the smaller size, I left alone the code that conditionally skips rendering this decoration inside unit tests and console.
The SVG has no
idand the JS targets it by looking at the previous element sibling, so the "double render" trick for the hover effect is still fine.