[13.x] Fix sub-minute scheduling skips at minute boundaries#59331
Merged
taylorotwell merged 3 commits intolaravel:13.xfrom Mar 25, 2026
Merged
[13.x] Fix sub-minute scheduling skips at minute boundaries#59331taylorotwell merged 3 commits intolaravel:13.xfrom
taylorotwell merged 3 commits intolaravel:13.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
3 tasks
The repeatEvents() method called endOfMinute() on startedAt directly, which mutated the Carbon instance. This caused the boundary to shift on each iteration, leading to skipped executions. Using copy() before endOfMinute() preserves the original timestamp. Also adds an early return if the minute boundary is crossed mid-iteration. Fixes laravel#57070 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JoshSalway
force-pushed
the
fix/framework-57070
branch
from
910566b to
0ea0cc8
Compare
Confirms the Carbon mutation bug is fixed — endOfMinute() was modifying $this->startedAt in place on each loop iteration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JoshSalway
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57070
repeatEvents()callsendOfMinute()directly on$this->startedAt, mutating the Carbon instance on each loop iteration. This corrupts the timestamp used for scheduling decisions, causing sub-minute tasks to skip executions at minute boundaries.Fix uses
copy()->endOfMinute()to preserve the original timestamp, and adds an early return if the minute boundary is crossed mid-iteration.Test included that verifies
startedAtis not mutated — fails on the buggy code, passes with the fix.