[13.x] Fix dynamic calls to incrementEachQuietly and decrementEachQuietly#60737
Merged
taylorotwell merged 1 commit intoJul 13, 2026
Merged
Conversation
…:__call These two methods were added recently (laravel#60720) as protected, but were not included in the list of methods that Model::__call forwards to the instance. Calling them dynamically on a model -- e.g. \->incrementEachQuietly(['votes' => 1]) -- was therefore forwarded to the query builder, which has no such method, and threw a BadMethodCallException. Every sibling (increment, decrement, incrementQuietly, decrementQuietly, incrementEach, decrementEach) is already listed; this adds the two missing quiet-each variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incrementEachQuietly()anddecrementEachQuietly(), added in #60720, are declaredprotectedbut were never added to the list of methodsModel::__call()runs on the model instance. Calling them dynamically therefore forwards to the query builder, which has no such method, and throws aBadMethodCallException:Their siblings (
increment,decrement,incrementQuietly,decrementQuietly,incrementEach,decrementEach) are all already listed, so this adds the two missing quiet-each variants.Also added regression tests that call both methods dynamically on a real model instance — the existing tests only went through public wrapper methods, which bypass
__calland left this uncovered.