[13.x] Preserve falsey concurrency exception parameters#60822
Merged
taylorotwell merged 1 commit intoJul 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
When a concurrent task fails while using the
ProcessDriver, the framework captures the exception in the child process, serializes it, and reconstructs it in the parent process.However, during the reconstruction process in
ProcessDriver.php, the driver usesarray_filter()without a callback to check if custom constructor parameters were captured:Because PHP's default
array_filterstrips out all falsey values, legitimate arguments like0,false, or""(empty string) are treated as completely absent. As a result, the framework incorrectly falls back to passing the exception's string message into the constructor instead of the actual arguments.If you throw a custom exception that expects a falsey integer or boolean value:
The
0parameter is discarded because it's falsey. When the driver attempts to reconstruct the exception, it passes the string message into the constructor instead of the integer0, which immediately crashes the application with aTypeError.After this PR
The reconstructed exception faithfully retains its original constructor parameters:
The presence check now explicitly filters out only
nullvalues. Valid non-falsey parameters remain unaffected, and the message fallback still cleanly handles cases where no constructor parameters could be captured at all.