[13.x] Optimize Str::ucfirst and Str::lcfirst using native PHP 8.4 functions#60864
Merged
taylorotwell merged 3 commits intoJul 22, 2026
Merged
Conversation
shaedrich
reviewed
Jul 22, 2026
Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com>
Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the
Str::ucfirstandStr::lcfirstmethods by utilizing PHP 8.4's nativemb_ucfirstandmb_lcfirstfunctions when they are available in the environment.Why this matters:
Currently, these methods extract the first character using
substr, mutate it (upper/lower), and concatenate it back with the rest of the string. Utilizing the native C-implemented multi-byte functions significantly reduces string segmenting overhead, avoids intermediate memory allocations, and provides a cleaner approach.Backward Compatibility:
Backward compatibility is fully maintained for older PHP versions via a
function_existsfallback.All existing
Strtests pass successfully.