Skip to content

[13.x] ColumnDefinition::unsigned takes a parameter, which should be documented#60875

Merged
taylorotwell merged 1 commit into
laravel:13.xfrom
afk11:13-column-definition-unsigned-arg
Jul 24, 2026
Merged

[13.x] ColumnDefinition::unsigned takes a parameter, which should be documented#60875
taylorotwell merged 1 commit into
laravel:13.xfrom
afk11:13-column-definition-unsigned-arg

Conversation

@afk11

@afk11 afk11 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The phpdoc for the unsigned method on ColumnDefinition doesn't mention that it takes a parameter that has a side effect.

Github has some public usages in search for ->unsigned(false)

@afk11 afk11 changed the title ColumnDefinition::unsigned takes a parameter, which should be documneted [13.x] ColumnDefinition::unsigned takes a parameter, which should be documneted Jul 24, 2026
@afk11 afk11 changed the title [13.x] ColumnDefinition::unsigned takes a parameter, which should be documneted [13.x] ColumnDefinition::unsigned takes a parameter, which should be documented Jul 24, 2026
@taylorotwell
taylorotwell merged commit ae6c531 into laravel:13.x Jul 24, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants