[13.x] Restore iterable support to Arr::every() and Arr::some()#60876
Merged
Conversation
shaedrich
reviewed
Jul 24, 2026
Comment on lines
+597
to
+607
| if (is_array($array)) { | ||
| return array_all($array, $callback); | ||
| } | ||
|
|
||
| foreach ($array as $key => $value) { | ||
| if (! $callback($value, $key)) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| return true; |
Contributor
There was a problem hiding this comment.
Wouldn't it be enough to call Arr::from() on the input before passing it to array_all()?
Suggested change
| if (is_array($array)) { | |
| return array_all($array, $callback); | |
| } | |
| foreach ($array as $key => $value) { | |
| if (! $callback($value, $key)) { | |
| return false; | |
| } | |
| } | |
| return true; | |
| return array_all(self::from($array), $callback); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arr::every()andArr::some()document support for iterable values, but currently pass them directly toarray_all()andarray_any(), which only accept arrays.As a result, passing an
ArrayIterator, generator, or other non-array iterable throws aTypeError.This change retains the native PHP helpers for arrays while restoring the original short-circuiting iteration behavior for other iterables.
Regression tests also ensure callback values and keys are passed correctly.