[13.x] Respect job delays when bulk pushing to QueueFake - #60916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueueFake::bulk()currently pushes every job immediately, regardless ofwhether the job defines a
#[Delay]attribute or a runtime$delayvalue.This differs from the production queue drivers, which respect these delays
during bulk dispatch.
This PR updates
QueueFake::bulk()to resolve each job's delay using the sameattribute resolution mechanism as the production drivers. Jobs with a delay
are passed to
later(), while jobs without a delay continue to usepush().This keeps bulk dispatch behavior consistent between
Queue::fake()andproduction queue connections without changing the behavior of non-delayed
jobs. Queue names, payload data, and existing pushed-job assertions remain
unchanged.
Regression tests cover bulk jobs with both
#[Delay]attributes and runtimedelays.