[13.x] Fake the pwnedpasswords API in ValidationPasswordRuleTest - #60927
Merged
taylorotwell merged 1 commit intoJul 30, 2026
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
lucasmichot
force-pushed
the
fix/uncompromised-password-test-network-call
branch
from
July 29, 2026 17:20
aabf67b to
5923e6d
Compare
…romised This test made a real network call to https://api.pwnedpasswords.com through NotPwnedVerifier, since it doesn't boot a full application container. On the GitHub Actions Windows runners this call sometimes fails, and since report() itself needs a bound ExceptionHandler, the catch block in NotPwnedVerifier::search() throws its own BindingResolutionException instead, masking the network error and failing the test intermittently. Binds Illuminate\Http\Client\Factory as a singleton in setUp() so Http::fake() controls the same instance the validator resolves, and fakes deterministic pwnedpasswords-style responses for the known passwords the test asserts against.
lucasmichot
force-pushed
the
fix/uncompromised-password-test-network-call
branch
from
July 29, 2026 17:21
5923e6d to
0030ae7
Compare
lucasmichot
changed the title
lucasmichot
marked this pull request as ready for review
July 29, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test made a real network call to https://api.pwnedpasswords.com. On the GitHub Actions Windows runners this call sometimes fails, and the error handling itself fails too (no
ExceptionHandlerbound in this test), so the real network error gets hidden and the test just fails:This fixes it by faking the HTTP response instead of calling the real API.
ValidationNotPwnedVerifierTestalready does this with mocks, so this test was the only one still using the network.This is not new: the test has always called the real API, since it was added in #36960. It only fails sometimes, when the network call is unreliable.