[13.x] Fix ReflectsClosures::firstClosureParameterTypes() returning wrong parameter's type - #60976
Merged
taylorotwell merged 1 commit intoAug 3, 2026
Conversation
lucasmichot
changed the title
Member
|
Has conflicts. |
taylorotwell
marked this pull request as draft
August 2, 2026 20:40
…rameter's type filter()->values() reindexed the array before grabbing index 0, so an untyped first parameter got silently dropped and a later typed parameter took its place instead of the expected RuntimeException. Also fixes proxy() helper not caching its static reflector instance.
lucasmichot
force-pushed
the
fix/reflects-closures-first-parameter-type
branch
from
August 3, 2026 04:58
47f5ce4 to
c6c0bce
Compare
Contributor
Author
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firstClosureParameterTypes()filtered out empty/null entries and reindexed before reading index0. If the first closure parameter had no type hint but a later one did, the later parameter's types silently shifted into index0instead of throwing the expectedRuntimeException.Also fixes the
proxy()helper, which rebuilt its reflector on every call instead of caching it likelazy()does.