[13.x] Fix Arr::forget() removing the wrong element - #61023
Merged
taylorotwell merged 2 commits intoAug 4, 2026
Merged
Conversation
`Arr::forget()` resets its working reference back to the top-level array
(`$array = &$original`) only *after* the shortcut that unsets an exact
top-level key. When a "dot" key is processed, the reference is left
pointing at a nested array, so the next key in the list is resolved
against that nested array instead of the top level.
$array = ['users' => ['name' => 'Joe', 'id' => 1], 'id' => 99];
Arr::forget($array, ['users.name', 'id']);
// before: ['users' => [], 'id' => 99] <- removed users.id
// after: ['users' => ['id' => 1]]
Moving the reset to the top of the loop makes every key resolve from the
top-level array, as intended. This also affects `Arr::except()`,
`Collection::except()`, `data_forget()` and `Uri::withoutQuery()`, which
all delegate here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arr::forget()resets its working reference back to the top-level array ($array = &$original) only after the shortcut that unsets an exact top-level key. When a "dot" key is processed, the reference is left pointing at a nested array, so the next key in the list is resolved against that nested array instead of the top level.The wrong element is removed and the requested one is kept, silently. Two dotted keys in a row are affected the same way:
Moving the reset to the top of the loop makes every key resolve from the top-level array, which is what the existing
// clean up before each passcomment intends.This also affects everything that delegates here:
Arr::except(),Collection::except(),data_forget()andUri::withoutQuery().Tests covering both orderings are added to the existing
testForget().