[13.x] Add the timeout in JobTimedOut - #61060
Merged
taylorotwell merged 1 commit intoAug 6, 2026
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Contributor
Author
|
The redis cluster tests are flaky, but, this is good to review. |
jackbayliss
marked this pull request as ready for review
August 5, 2026 17:45
jackbayliss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can listen to this event and access the job, but the timeout may also come from the worker.
Ie in cases such as
queue:work --queue=notifications,emails,logs --timeout=120This means we may see loads of
JobTimedOutevents and assume it's the job, when it's actually the worker.This PR adds the timeout in seconds to the event so we can see easier if it was the worker, the job etc.
I haven't added a test as it's within a signal, rest assured I'll check the dev branch tho if this is accepted 🤓
Thanks man