[13.x] Adjust creationTimeOfOldestPendingJob for DatabaseQueue - #61101
Draft
jackbayliss wants to merge 1 commit into
Draft
[13.x] Adjust creationTimeOfOldestPendingJob for DatabaseQueue#61101jackbayliss wants to merge 1 commit into
creationTimeOfOldestPendingJob for DatabaseQueue#61101jackbayliss wants to merge 1 commit into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eyes were crusin' and noticed this.
This should be
created_at, notavailable_atIf a job is set as delayed, the
available_atis set in the future, so it's not when it actually was created. This matches Redis then.The docblock specifies
Get the creation timestamp of the oldest pending jobI targeted 13.x as feels like a bug fix, granted this could break some tests so I can move it to 14.x if u prefer
Added a test too.
TLDR is this matches Redis now..