[5.1] Easy application namespace determination #8098
Merged
+47
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrilot
changed the title
Collaborator
There was a problem hiding this comment.
I don't really like seeing helper functions for ioc stuff in the core. Feels really hacky.
Contributor
Author
There was a problem hiding this comment.
Maybe.
Let's see what Taylor thinks about that and the PR as a whole.
Member
There was a problem hiding this comment.
You can use $this->laravel to get to the application from a Console command.
arrilot
force-pushed
the
application_namespace
branch
from
dabb057 to
0c0a6b8
Compare
Contributor
Author
|
Cleaned up and squashed |
Collaborator
There was a problem hiding this comment.
This should be protected.
Removed unused import
arrilot
force-pushed
the
application_namespace
branch
from
0c0a6b8 to
671f671
Compare
taylorotwell
added a commit
that referenced
this pull request
Mar 24, 2015
[5.1] Easy application namespace determination
Member
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #8084
Okay, so I've spent some time trying to investigate how to determine application namespace outside laravel core (in a package in my case)
I found it pretty confusing because:
Illuminate\Console\AppNamespaceDetectorTrait)What about straightforward
app()->getNamespace()?