[5.3] Make method Application::getKernel public #12801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Why? |
Member
|
If nobody has a use for it and it's not used by the framework we might should just delete it? |
Collaborator
|
Looks like it was just forgotten to be deleted to me. |
Collaborator
Collaborator
|
That commit I just linked to should have deleted the method, but it didn't. |
Contributor
Author
|
Compare: Don't you think hardcoding the interface in the former is somehow clumsy? |
Member
|
Going to hold off on this. |
Contributor
Author
|
Method has been removed: f4fd485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has been introduced in #8098 but isn't used by laravel itself since #9100.
As I think it's an useful one, maybe we should promote it to public.
ping @arrilot