Skip to content

Conversation

@arrilot
Copy link
Contributor

@arrilot arrilot commented Jun 5, 2015

Closes #8997

There are some problems with app namespace determination that was introduced in #8084

  1. Nested namespaces doesn't work atm, but in L5.0 they work fine.
  2. In some rare cases kernel classes can be overwriten since they are bound into the container in laravel/laravel https://github.com/laravel/laravel/blob/develop/bootstrap/app.php

So I guess it's better to return to the code we have in 5.0, sorry.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is formatted wrongly.

@arrilot arrilot force-pushed the support_nested_app_namespace branch from 420a75b to 639f85d Compare June 5, 2015 20:33
taylorotwell added a commit that referenced this pull request Jun 7, 2015
@taylorotwell taylorotwell merged commit 6a785ae into laravel:5.1 Jun 7, 2015
@arrilot arrilot deleted the support_nested_app_namespace branch June 7, 2015 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants