Skip to content

Conversation

@peter279k
Copy link
Contributor

@peter279k peter279k commented Mar 15, 2019

Changed log

  • Update the composer execution path on NewCommand::findComposer command.

Actually, the original php compoer.phar string result is not correct.

And this will not specify the current path to let PHP binary know where the composer.phar can execute.

It should use the current composer path to tell PHP binary to execute composer.phar.

Instruction

Environment

  • Ubuntu 18.04
  • composer version is 1.8.4.

Here are steps about reproducing the issue.

  • Firstly, we use the composer require laravel/installer command.
  • Then using the vendor/bin/laravel new blog to create the new Laravel project.
  • It will get the error message in following image during building the Laravel project.

image

@taylorotwell
Copy link
Member

Please provide instructions for how to recreate the bug locally.

@taylorotwell
Copy link
Member

Closing pending inactivity. Feel free to re-open a PR with reproduction instructions.

@peter279k
Copy link
Contributor Author

I have already created the instructions on the original comments.

@driesvints
Copy link
Member

@peter279k you should have pinged Taylor about that. We can't know if you updated the original comment unless we check the "edited" history (which we don't always do). I see you've already created a new PR, thanks 👍

@peter279k peter279k deleted the update_composer_path branch April 22, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants