Replace connection instance with repositories and add support to change the database connection name #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced auth codes database connection with repository Replaced refresh token database connection with repository
Contributor
Author
|
Changed my mind, thought about something much simpler. Will issue a new PR regarding this topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the usage of Database Connection instances for the auth codes and refresh tokens in favor of repositories, similar to: laravel/passport:#90
And this adds the ability to change the connection name used during queries using
Passport::setConnectionName('name-here').This somewhat resolves my issue mentioned here: laravel/framework#15597