Use Token model/repository when working with AccessTokenRepository #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 16, 2016 23:36
Closed
This was referenced Sep 25, 2016
|
@taylorotwell when it will be merged in release? This PR could help a LOT in using Passport with mongodb. |
Member
|
It's already been released. |
|
@taylorotwell I mean do you plan to merge it in 1.0 version? Because now it's only available in dev-master build. |
Contributor
|
Please don't. Master branch breaks scope functionality - see #148 You need an Auth Code Repository too with scopes cast to/from array and then to change FormatScopesForStorage not to encode the scopes. Or just remove cast from AccessToken eloquent model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the usage of using the Database Connection in favor of TokenRepository which then calls
Tokendirectly.A big benefit of this is so that Model events can be observed when creating Access Tokens.
I believe this would cover at least part of Issue #77.