Allow support for symfony/process 5.0 #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravenberg
reviewed
Nov 29, 2019
| "illuminate/container": "~5.1 | ^6.0", | ||
| "mnapoli/silly": "~1.0", | ||
| "symfony/process": "~2.7|~3.0|~4.0", | ||
| "symfony/process": "~2.7|~3.0|~4.0|~5.0", |
Contributor
There was a problem hiding this comment.
Hi, would it hurt to remove the ~2.7 and ~3.0 version requirements?
Contributor
Author
There was a problem hiding this comment.
Potentially.
I haven't gone back and checked what would break if we forced those out. Ideally forcing a newer PHP version would be easier to maintain
... but there are still people who do 5.6 (via unofficial taps of course), so if it's not necessary to break things, then I've just been leaving those around.
ravenberg
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with current symfony release updates