Skip to content

Allow support for symfony/process 5.0 #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattstauffer merged 1 commit into from
Nov 30, 2019
Merged

Allow support for symfony/process 5.0 #845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"php": ">=5.6",
"illuminate/container": "~5.1 | ^6.0",
"mnapoli/silly": "~1.0",
"symfony/process": "~2.7|~3.0|~4.0",
"symfony/process": "~2.7|~3.0|~4.0|~5.0",
Copy link
Contributor

@ravenberg ravenberg Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, would it hurt to remove the ~2.7 and ~3.0 version requirements?

Copy link
Contributor Author

@drbyte drbyte Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially.
I haven't gone back and checked what would break if we forced those out. Ideally forcing a newer PHP version would be easier to maintain
... but there are still people who do 5.6 (via unofficial taps of course), so if it's not necessary to break things, then I've just been leaving those around.

"nategood/httpful": "~0.2",
"tightenco/collect": "^5.3 | ^6.0"
},
Expand Down