Skip to content

fix article control buttons #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2021
Merged

fix article control buttons #731

merged 4 commits into from
Nov 13, 2021

Conversation

@faissaloux
Copy link
Contributor

@faissaloux faissaloux commented Nov 8, 2021

resolves #728

2021-11-09.00-25-36.mp4

@driesvints
Copy link
Member

driesvints commented Nov 9, 2021

I like this. Can we make all buttons like this? Also pin and delete.

I also think we need different icons for publish and decline. Maybe these two?

Approve: https://blade-ui-kit.com/blade-icons/heroicon-s-check
Decline: https://blade-ui-kit.com/blade-icons/heroicon-s-x

joedixon
joedixon requested changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@joedixon joedixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this too, great job. Just a couple of minor formatting tweaks from me.

@faissaloux faissaloux requested a review from joedixon November 12, 2021 15:35
@joedixon
Copy link
Contributor

joedixon commented Nov 12, 2021

@driesvints I'm happy with this when you are

@driesvints driesvints merged commit d776a99 into laravelio:main Nov 13, 2021
@driesvints
Copy link
Member

driesvints commented Nov 13, 2021

Thanks @faissaloux!

@faissaloux faissaloux deleted the fix-article-control-buttons branch November 13, 2021 14:13
@driesvints
Copy link
Member

driesvints commented Nov 13, 2021

I just noticed this PR causes a weird issue with buttons expanding on the bottom padding when you hover over them. Can we get that fixed?

@faissaloux
Copy link
Contributor Author

faissaloux commented Nov 13, 2021

Yes @driesvints I just noticed the same issue I'll fix it

@faissaloux faissaloux mentioned this pull request Nov 13, 2021
Merged
@faissaloux
Copy link
Contributor Author

faissaloux commented Nov 13, 2021

@driesvints #732 fixes this height issue

@driesvints
Copy link
Member

driesvints commented Nov 18, 2021

@faissaloux I just noticed that I can't seem to click any of the buttons anymore in Safari after this.

@joedixon
Copy link
Contributor

joedixon commented Nov 18, 2021

@driesvints fixed here #747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joedixon joedixon Awaiting requested review from joedixon

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix button styling

3 participants

@faissaloux @driesvints @joedixon