Skip to content

Fix modals #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

Fix modals #747

merged 1 commit into from
Nov 18, 2021

Conversation

@joedixon
Copy link
Contributor

@joedixon joedixon commented Nov 18, 2021

Modals were not triggering on the show article page. Refactored to use the event rather than relying on parent state.

@joedixon joedixon mentioned this pull request Nov 18, 2021
Merged
@joedixon joedixon requested a review from driesvints November 18, 2021 10:21
@driesvints driesvints merged commit b2fa88b into main Nov 18, 2021
@driesvints
Copy link
Member

driesvints commented Nov 18, 2021

Thanks!

@driesvints driesvints deleted the fix-article-control-buttons branch November 18, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driesvints driesvints Awaiting requested review from driesvints

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joedixon @driesvints