Retry the gitleaks download - #140
Merged
Merged
Conversation
The secrets job failed on a PR with `curl: (35) Recv failure: Connection reset by peer` — the binary download never completed, so nothing was ever scanned. Since the deploy gate now requires this job, a blip in GitHub Releases blocks a release outright, and the failure reads like a detected secret until you open the log. Five retries with a connect timeout make the transient case self-healing while a genuine outage still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
secretsjob failed on #139 with:The gitleaks binary never downloaded, so nothing was scanned. A re-run passed untouched.
Two reasons this is worth fixing rather than re-running when it happens:
Five retries with a connect timeout make the transient case self-healing; a genuine outage still fails the job.
Verified with actionlint.