Skip to content

docs(calendar): clarify identity selection by event ownership - #2071

Merged
calendar-assistant merged 1 commit into
mainfrom
docs/calendar-identity-guidance
Jul 28, 2026
Merged

docs(calendar): clarify identity selection by event ownership#2071
calendar-assistant merged 1 commit into
mainfrom
docs/calendar-identity-guidance

Conversation

@calendar-assistant

@calendar-assistant calendar-assistant commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Reframe the calendar skill's identity section around event ownership instead of framing --as bot purely as a "wrong" choice that returns empty results. This gives agents clearer guidance on when each identity applies.

Changes

  • Replace the BAD/GOOD example pair with an ownership-based rule: --as user for the logged-in user's own events (default, most cases), --as bot for events the bot creates or participates in.
  • Update the code examples so both use the same +agenda command, differing only by --as user / --as bot.

Test Plan

  • Documentation-only change (no code affected)
  • Rendered Markdown reviewed for correct formatting

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Updated calendar guidance to clarify how to choose the identity based on agenda ownership.
    • Added examples for using --as user and --as bot.
    • Removed outdated guidance about bot access returning empty calendar lists.

Reframe the identity section around event ownership: use `--as user`
for the logged-in user's own events and `--as bot` for events the bot
creates or participates in, with matching `+agenda` examples.
@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates the Lark calendar skill documentation to select --as user or --as bot based on agenda ownership, with revised examples.

Changes

Calendar identity guidance

Layer / File(s) Summary
Agenda ownership identity selection
skills/lark-calendar/SKILL.md
Adds guidance for using --as user with logged-in user schedules and --as bot with bot-created or bot-owned schedules, including updated commands.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: documentation

Suggested reviewers: liangshuo-1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the documentation change around identity selection by event ownership.
Description check ✅ Passed The description matches the template and includes summary, changes, test plan, and related issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/calendar-identity-guidance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-calendar/SKILL.md`:
- Around line 19-28: Update the “按日程归属选身份” guidance to remove the claim that
--as user is the CLI default. Describe it as the recommended choice for the
logged-in user’s schedules, and state that omitting --as uses the
credential-derived identity hint, which may fall back to bot.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b136efa8-16df-4a86-b3a5-879049450719

📥 Commits

Reviewing files that changed from the base of the PR and between 3d2c10c and fecb115.

📒 Files selected for processing (1)
  • skills/lark-calendar/SKILL.md

Comment thread skills/lark-calendar/SKILL.md
@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@fecb115b2173bf4e24b76604725a75f3dcb4ce96

🧩 Skill update

npx skills add larksuite/cli#docs/calendar-identity-guidance -y -g

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.16%. Comparing base (3d2c10c) to head (fecb115).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2071   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files         912      912           
  Lines       96451    96451           
=======================================
  Hits        72495    72495           
  Misses      18380    18380           
  Partials     5576     5576           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calendar-assistant
calendar-assistant merged commit 4c1c5f5 into main Jul 28, 2026
39 of 45 checks passed
@calendar-assistant
calendar-assistant deleted the docs/calendar-identity-guidance branch July 28, 2026 06:05
@liangshuo-1 liangshuo-1 mentioned this pull request Jul 28, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants