Skip to content

0728 fix url - #2079

Merged
zhangjun-bytedance merged 1 commit into
mainfrom
feat/0728_fix_url
Jul 28, 2026
Merged

0728 fix url#2079
zhangjun-bytedance merged 1 commit into
mainfrom
feat/0728_fix_url

Conversation

@zhangjun-bytedance

@zhangjun-bytedance zhangjun-bytedance commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Changes

  • Change 1
  • Change 2

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark-cli <domain> <command> flow works as expected

Related Issues

  • None

Summary by CodeRabbit

  • Bug Fixes
    • Updated calendar image preview links to use the correct default download host for Feishu.
    • Preserved existing Lark-specific preview routing and retained current image sizing options (including width/height and optional sizing parameters).

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dcb36aec-de86-4b6b-b4c1-23d8d30a8902

📥 Commits

Reviewing files that changed from the base of the PR and between 8c256fe and 255b908.

📒 Files selected for processing (2)
  • shortcuts/calendar/description_rich_images.go
  • shortcuts/calendar/description_rich_images_test.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • shortcuts/calendar/description_rich_images.go

📝 Walkthrough

Walkthrough

The calendar image preview URL builder now uses internal-api-drive-stream.feishu.cn by default. The existing Lark brand override and URL parameters remain unchanged, with the test expectation updated accordingly.

Changes

Calendar image preview

Layer / File(s) Summary
Update preview host selection
shortcuts/calendar/description_rich_images.go, shortcuts/calendar/description_rich_images_test.go
The default preview download host changes to the Feishu domain while the Lark-specific host override remains unchanged, and the Feishu host assertion is updated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • larksuite/cli#1975: Updates related calendar rich-description image rewriting that generates these preview URLs.

Suggested labels: bugfix

Suggested reviewers: calendar-assistant

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is just the template placeholders and does not include the required summary, changes, or test details. Fill in the Summary, Changes, and Test Plan sections with the actual implementation details and verification steps.
Title check ❓ Inconclusive The title is vague and only says 'fix url' without identifying the specific calendar preview host change. Use a clearer title that names the actual change, such as updating the calendar image preview URL host for Feishu.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/0728_fix_url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Jul 28, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@shortcuts/calendar/description_rich_images.go`:
- Line 160: Update the BrandFeishu host assertion in the relevant test to expect
"feishu.cn" instead of "larkoffice", matching the host produced by the builder.
Keep the BrandLark assertion expecting "larksuite".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cfe2b420-cedb-4c6d-bcf5-17cc6065b67b

📥 Commits

Reviewing files that changed from the base of the PR and between 1b173e1 and 8c256fe.

📒 Files selected for processing (1)
  • shortcuts/calendar/description_rich_images.go

Comment thread shortcuts/calendar/description_rich_images.go
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@255b9082a6f3e23201b8ed2711c21c0a43f09573

🧩 Skill update

npx skills add larksuite/cli#feat/0728_fix_url -y -g

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.16%. Comparing base (1b173e1) to head (255b908).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2079   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files         912      912           
  Lines       96475    96475           
=======================================
  Hits        72517    72517           
  Misses      18381    18381           
  Partials     5577     5577           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhangjun-bytedance
zhangjun-bytedance merged commit d2e22c5 into main Jul 28, 2026
29 of 42 checks passed
@zhangjun-bytedance
zhangjun-bytedance deleted the feat/0728_fix_url branch July 28, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants