ci: allow concurrent live e2e jobs - #2182
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe ChangesLive E2E CI configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/ci-workflow.test.sh`:
- Around line 259-260: Update the concurrency detection condition in the
contract test to recognize all valid job-level concurrency forms, including
standalone mapping keys, inline values, and flow-style values. Ensure the check
still targets the job-level section and rejects any later job-level concurrency
declaration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 757b7e18-66e5-47c6-be0f-7b47e9d1e447
📒 Files selected for processing (2)
.github/workflows/ci.ymlscripts/ci-workflow.test.sh
💤 Files with no reviewable changes (1)
- .github/workflows/ci.yml
sang-neo03
approved these changes
Aug 4, 2026
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@2b3d4715bc84c971088fc45eae76f7ef9ca68f5e🧩 Skill updatenpx skills add yxzhaao/cli#ci/allow-concurrent-live-e2e -y -g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e-liveEach live job already fetches one tenant access token and reuses it across CLI subprocesses, so concurrent PRs no longer multiply token exchange requests per command. Domain-directed package selection also limits each run to affected E2E packages.
Tradeoff
Different pull requests can now exercise the shared test tenant at the same time. This may expose service-level throttling or resource contention, so live E2E stability should be monitored after merge.
Test plan
make script-testmake quality-gate QUALITY_GATE_CHANGED_FROM=origin/maingit diff --checkSummary by CodeRabbit