Skip to content

ci: allow concurrent live e2e jobs - #2182

Merged
sang-neo03 merged 1 commit into
larksuite:mainfrom
yxzhaao:ci/allow-concurrent-live-e2e
Aug 4, 2026
Merged

ci: allow concurrent live e2e jobs#2182
sang-neo03 merged 1 commit into
larksuite:mainfrom
yxzhaao:ci/allow-concurrent-live-e2e

Conversation

@yxzhaao

@yxzhaao yxzhaao commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the repository-wide single-slot concurrency group from e2e-live
  • keep workflow-level same-PR run deduplication, prerequisite gates, and the stale-run startup check
  • add a workflow contract assertion that prevents job-level live E2E serialization from being reintroduced

Each live job already fetches one tenant access token and reuses it across CLI subprocesses, so concurrent PRs no longer multiply token exchange requests per command. Domain-directed package selection also limits each run to affected E2E packages.

Tradeoff

Different pull requests can now exercise the shared test tenant at the same time. This may expose service-level throttling or resource contention, so live E2E stability should be monitored after merge.

Test plan

  • make script-test
  • make quality-gate QUALITY_GATE_CHANGED_FROM=origin/main
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Simplified E2E testing pipeline configuration to improve CI/CD efficiency.
    • Updated test validations to align with workflow modifications.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The e2e-live job no longer uses repository-wide concurrency settings. CI workflow tests now verify the absence of job-level concurrency and update related assertion messages.

Changes

Live E2E CI configuration

Layer / File(s) Summary
Remove e2e-live concurrency settings
.github/workflows/ci.yml, scripts/ci-workflow.test.sh
The workflow removes the e2e-live concurrency block. Tests retain the 30-minute timeout check, validate the absence of job-level concurrency, and update dependency and exclusion assertion messages.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: hanshaoshuai-k

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: allowing concurrent live E2E jobs.
Description check ✅ Passed The description explains the motivation, scope, tradeoff, and test plan, but it omits the template's explicit Changes and Related Issues sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Aug 4, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/ci-workflow.test.sh`:
- Around line 259-260: Update the concurrency detection condition in the
contract test to recognize all valid job-level concurrency forms, including
standalone mapping keys, inline values, and flow-style values. Ensure the check
still targets the job-level section and rejects any later job-level concurrency
declaration.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 757b7e18-66e5-47c6-be0f-7b47e9d1e447

📥 Commits

Reviewing files that changed from the base of the PR and between 95a0449 and 2b3d471.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • scripts/ci-workflow.test.sh
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml

Comment thread scripts/ci-workflow.test.sh
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@2b3d4715bc84c971088fc45eae76f7ef9ca68f5e

🧩 Skill update

npx skills add yxzhaao/cli#ci/allow-concurrent-live-e2e -y -g

@sang-neo03
sang-neo03 merged commit 8b50cae into larksuite:main Aug 4, 2026
23 of 37 checks passed
@liangshuo-1 liangshuo-1 mentioned this pull request Aug 4, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants