fix(im): unpin search identity after bot support landed - #2208
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthrough
ChangesMessage search identity
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9b21b53 to
00031fa
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@89429b456f5ae95502d58ee7c4df55a9c6f86b94🧩 Skill updatenpx skills add larksuite/cli#fix/im-search-affordance-dual-identity -y -g |
#2194 extended `im +messages-search` to `AuthTypes: {user, bot}` but left the affordance example and the skill reference asserting user-only, so the dual-identity guard added by #2199 fails on main. sa: safe doc: affordance/im.md, skills/lark-im cfg: none test: go test -race ./cmd/... ./internal/... ./shortcuts/... ./extension/...
00031fa to
89429b4
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2208 +/- ##
==========================================
- Coverage 76.10% 76.08% -0.03%
==========================================
Files 983 983
Lines 103079 103429 +350
==========================================
+ Hits 78448 78692 +244
- Misses 18694 18752 +58
- Partials 5937 5985 +48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
mainunit tests are red since #2194 (b546516b) and stay red on50b4c688, blocking every open PR (e.g. #2203). #2194 extendedim +messages-searchtoAuthTypes: {"user", "bot"}but did not update the affordance example or the skill reference, both of which still assert user-only. This PR closes that gap.The failing assertion:
Bisect over
main:960bdf6d(#2199, added the guard) ok →fcdef499ok →b546516b(#2194) FAIL →50b4c688FAIL.main's own push CI shows the same transition. #2194's PR checks were green because its run (31003425323,run_attempt=3) was created at 2026-08-05T11:55Z againstbase_sha=0848a5b4, a tree that predates #2199 — the re-run reused that stale merge ref, so the new guard never executed.Changes
affordance/im.md: drop--as userfrom the+messages-searchexample and the stale "user-only" wording. Nothing is added in their place — which identities a shortcut accepts is already structured metadata.internal/affordance/im_source_test.go: update the audited example and remove the now-unusedexplicit-userderivation, whose whole job was asserting the source doc said "User identity only".skills/lark-im/references/lark-im-messages-search.md: delete the header callout "User identity only. Bot identity is not supported." and correct the--asrow in the flag table. Both contradicted the code and line 166 of the same file, which feat: support bot identity for search shortcuts #2194 updated to tell agents to run--as bot. The callout is deleted rather than reworded: identity support is already carried by--asand the shortcut metadata, and generic "do not pin--as" guidance belongs inlark-shared, not in every reference.skills/lark-im/references/lark-im-message-enrichment.md: drop "user-only" from the scope note describing the search command'sScopesfield.No production code changes —
AuthTypesand the search behaviour from #2194 are untouched.Test Plan
go test -race -count=1 ./cmd/... ./internal/... ./shortcuts/... ./extension/...— all green (reproduced the failure on clean50b4c688first)node scripts/skill-format-check/index.js— passedgofmt/go vetclean on touched packages--as userinaffordance/im.mdagainst each shortcut'sAuthTypes: the remaining ones are genuinely user-only (+flag-*,+feed-*) or raw API commands not covered by the guardRelated Issues
main34ddb5bf("validate bot search filters and enrichment scopes") means bot-identity filter/scope limits are still unvalidated;shortcuts/minutesgot the sameAuthTypesextension but has noaffordance/minutes.mdyet, so nothing guards it there.Summary by CodeRabbit
New Features
Documentation