feat(sheets): combine chart workflows and special chart types - #2374
feat(sheets): combine chart workflows and special chart types#2374zhengzhijiej-tech wants to merge 19 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2374 +/- ##
==========================================
- Coverage 76.43% 76.28% -0.16%
==========================================
Files 1046 1047 +1
Lines 115162 116570 +1408
==========================================
+ Hits 88022 88921 +899
- Misses 20377 20717 +340
- Partials 6763 6932 +169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| var ranges []string | ||
| start := 0 | ||
| inQuote := false | ||
| for i := 0; i <= len(value); i++ { |
| if err != nil { | ||
| return err | ||
| } | ||
| input, err := chartConfigUpdateInput(runtime, token, sheetID, sheetName) |
| if err != nil { | ||
| return err | ||
| } | ||
| input, err := chartDataUpdateInput(runtime, token, sheetID, sheetName) |
Problem
Chart workflow improvements and bubble/waterfall/pareto support were developed on separate branches. Keeping them separate leaves the semantic shortcuts, batch paths, generated schemas, and bundled Sheets skill out of sync.
Changes
lark-sheetsskill from the combined sheet-skill-spec output, including the chart layout check script+batch-updatecompatible with chart operations while guiding pure chart batches to the dedicated shortcutsValidation
go test -count=1 ./shortcuts/sheets/...make unit-testmake vetmake fmt-checknode scripts/skill-format-check/index.js skillsmake quality-gate QUALITY_GATE_CHANGED_FROM=origin/main