Chat screen header buttons: contact's map, requesting telemetry, and info dialog. - #30
Merged
Merged
Conversation
The eye/info button and the refresh/telemetry button both opened the same telemetry modal (which already shows contact battery/location/distance and requests fresh telemetry). Keep the telemetry button; remove the eye one and its now-dead path (headerNameCb, onInfo/OnInfoCallback, the UIManager onInfo wiring). Trims the header to back · title · map · telemetry · mute. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
refreshChatMapButton() now also runs on the 1s status cadence while the chat screen is foreground, so the header map button appears when an advert brings in a position and disappears when a last-known fix ages out of its freshness window (bestKnownLocation is time-sensitive). Mirrors the convo list, which already re-renders its GPS badge periodically. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The header map button now appears only when we have a known position for the DM contact, so it never opens the map with nothing to centre on. open() keeps it hidden; UIManager::refreshChatMapButton() reveals it on chat open and after a telemetry reply yields a position (bestKnownLocation: telemetry → advert → heard). Also added the missing !self guards to mapBtnCb/telemBtnCb for consistency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jason-s13r
changed the title
laserir
added a commit
that referenced
this pull request
Jun 22, 2026
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
laserir
added a commit
that referenced
this pull request
Jun 22, 2026
PR #30 made the chat contact name a plain title; telemetry/info is the header refresh button. Correct the README references (map view, config comment, tile-pack note, key-actions table) and note the changed behaviour in the changelog. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
laserir
added a commit
that referenced
this pull request
Jun 22, 2026
Bump MCLITE_VERSION 0.3.9 -> 0.4.0 and finalize the changelog (the [Unreleased] window becomes 0.4.0): companion telemetry request, over-the-air contact sharing, on-device add/remove of contacts/channels/rooms, 19 radio presets + roller (#29), chat-header map/telemetry buttons (#30), unified modals, and alias-display fixes. LANG_VERSION realigned 41 -> 40 (dotless 0.4.0 convention) across defaults.h, the three SD lang files, and the config tool's embedded copies. README flash examples updated to v0.4.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat screen header buttons contact's map, requesting telemetry, and info dialog.
and uses lv_win for the chat screen.