sbsrl_offline - sooper compatibility - #248
Merged
Merged
Conversation
yardenas
requested changes
Oct 31, 2025
| backup_qc_params = sbsrl_network.backup_qc_network.init(key_qr) | ||
| backup_qr_params = sbsrl_network.backup_qc_network.init( | ||
| key_qr | ||
| ) # TODO: can I use the same network for backup_qc/backup_qr? |
Collaborator
There was a problem hiding this comment.
Technically yes, but let's separate them to avoid inconsistencies
Collaborator
Author
There was a problem hiding this comment.
ok it should be ok now
| backup_policy_params=params[1], | ||
| backup_policy_params=params[ | ||
| 1 | ||
| ], # TODO: can remove backup_policy_params? |
Collaborator
Author
There was a problem hiding this comment.
Where are we using them? it seems to me we never touch them in sbsrl
Collaborator
There was a problem hiding this comment.
Ah, I see. But if you train a prior policy for sooper you'll need them no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.