Refactor/358 fix dcm facet srp dynamic effector#359
Merged
Conversation
codyallard28
approved these changes
Apr 8, 2025
Collaborator
|
Gosh I thought we already brought this into develop |
This ensures that the transformation is active and the facet normal is rotated correctly into the spacecraft body frame
patkenneally
force-pushed
the
refactor/358-fix-dcm-facetSRPDynamicEffector
branch
from
April 8, 2025 15:11
0a80604 to
82b15f6
Compare
Collaborator
Author
|
@codyallard28 @patkenneally I just ran pre-commit on the srp module fiiles, this PR should be ready to merge after the checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The computed
dcm_BB0DCM in thefacetSRPDynamicEffectormodule that maps the facet normal vectors to the spacecraft body frame needs to be transposed. The rotation of the facet normal vector is an active rotation; however the computed DCM in the module is for a passive rotation. The correct transformation is therefore the transpose of the passive rotation matrix.This bug was pointed out by @rcalaon when he was not obtaining expected results from the module. Applying the transpose resolved the issue and he sees the expected results.
Verification
The transformation is identically updated in both the module and the module unit test.
Documentation
The documentation is updated to reflect this change.
Future work
The module unit test needs to be improved. The module and documentation also needs to be cleaned up.